linux-kernel - Re: [linux-cifs-client] [PATCH] cifs: wrap cifs_dnotify_thread in CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090122201719.4d1f0b75@tleilax.poochiereds.net>
Date:	Thu, 22 Jan 2009 20:17:19 -0500
From:	Jeff Layton <jlayton@...hat.com>
To:	Steve French <smfrench@...il.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-cifs-client@...ts.samba.org,
	linux-kernel@...r.kernel.org, Christoph Hellwig <hch@...radead.org>
Subject: Re: [linux-cifs-client] [PATCH] cifs: wrap cifs_dnotify_thread in 
 CONFIG_BROKEN

On Thu, 22 Jan 2009 17:56:09 -0600
Steve French <smfrench@...il.com> wrote:

> One of the obvious reasons that we could throw away the idea of a cifs
> dnotify thread for cifs is if we could guarantee that all of the
> functions in include/linux/fsnotify.h are nonblocking.  If the
> fsnotify.h worker functions are nonblocking then we could safely
> process all of the notify responses in cifs_demultiplex_thread (since
> we wouldn't have to queue them) without clogging up response
> processing for the socket.   Note that notify responses are unusual -
> they don't have an application thread waiting on them ("multishot"
> responses) typically (there is only one other type of SMB response
> that does not have an application thread associated with it).
> 

I'm not arguing against the need for a kthread to handle notifications.
Heck, I'm even ok with more than one thread if it's necessary.

We simply don't have such an implementation today. Until we do, this
kthread is just dead weight. There's simply no need to keep this in
place until we have working code that uses it.

-- 
Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/