| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200901232159.18863.david-b@pacbell.net> Date: Fri, 23 Jan 2009 21:59:18 -0800 From: David Brownell <david-b@...bell.net> To: Bryan Wu <cooloney@...nel.org> Cc: gregkh@...e.de, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] usb: composite: Fix bug: should test set_alt function pointer before use it On Wednesday 07 January 2009, Bryan Wu wrote: > Signed-off-by: Bryan Wu <cooloney@...nel.org> Include a real patch comment -- "test the *correct* function pointer" would suffice, and: Acked-by: David Brownell <dbrownell@...rs.sourceforge.net> > --- > drivers/usb/gadget/composite.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c > index f2da026..363951e 100644 > --- a/drivers/usb/gadget/composite.c > +++ b/drivers/usb/gadget/composite.c > @@ -772,7 +772,7 @@ composite_setup(struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl) > f = cdev->config->interface[w_index]; > if (!f) > break; > - if (w_value && !f->get_alt) > + if (w_value && !f->set_alt) > break; > value = f->set_alt(f, w_index, w_value); > break; > -- > 1.5.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists