linux-kernel - Re: serial8250 madness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090124091239.7bdf45a2@torg>
Date:	Sat, 24 Jan 2009 09:12:39 -0600
From:	Clark Williams <williams@...hat.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Andrew Walrond <andrew@...rond.org>, linux-kernel@...r.kernel.org
Subject: Re: serial8250 madness

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, 23 Jan 2009 18:00:33 +0000
Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> 
> The big outstanding bug I know about is the incompatibility between the
> PnP 8250 drivers and serial console - that may be your machine C case.
> That one is rather hard to fix so on the long rather than short term hit
> list.
> 
> Alan


I spend a few days trying to figure out a panic in the uart driver that
turned out to be this issue. Would it make sense to add the following?

diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index 579d63a..35acc6b 100644
- --- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -91,7 +91,7 @@ config SERIAL_8250_PCI
 
 config SERIAL_8250_PNP
        tristate "8250/16550 PNP device support" if EMBEDDED
- -       depends on SERIAL_8250 && PNP
+       depends on SERIAL_8250 && PNP && ! SERIAL_8250_CONSOLE
        default SERIAL_8250
        help
          This builds standard PNP serial support. You may be able to

Clark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (GNU/Linux)

iEYEARECAAYFAkl7L/MACgkQHyuj/+TTEp21NACgpQI89LMX5ZtJbVlMcpa9A/I0
6JkAoIa5Nwt4mvm6UJGzGkoUGKOCzn5V
=YUtB
-----END PGP SIGNATURE-----