linux-kernel - Re: [Linux 2.6.29-rc2] BUG: using smp_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8db1092f0901250830m3300f497yba50afc1a4f8d8e2@mail.gmail.com>
Date:	Sun, 25 Jan 2009 17:30:59 +0100
From:	Maciej Rutecki <maciej.rutecki@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [Linux 2.6.29-rc2] BUG: using smp_processor_id() in preemptible

2009/1/25 Andrew Morton <akpm@...ux-foundation.org>:
[...]
>
>
> Does this fix it?

Yes, message has gone. Thanks for help.

Tested-by Maciej Rutecki <maciej.rutecki@...il.com>
>
> --- a/kernel/hrtimer.c~a
> +++ a/kernel/hrtimer.c
> @@ -562,7 +562,7 @@ static int hrtimer_reprogram(struct hrti
>  /*
>  * Retrigger next event is called after clock was set
>  *
> - * Called with interrupts disabled via on_each_cpu()
> + * Called with interrupts disabled.
>  */
>  static void retrigger_next_event(void *arg)
>  {
> @@ -614,8 +614,12 @@ void clock_was_set(void)
>  */
>  void hres_timers_resume(void)
>  {
> +       unsigned long flags;
> +
>        /* Retrigger the CPU local events: */
> +       local_irq_save(flags);
>        retrigger_next_event(NULL);
> +       local_irq_restore(flags);
>  }
>
>  /*
> _
>
>



-- 
Maciej Rutecki
http://www.maciek.unixy.pl
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/