linux-kernel - Re: [PATCH] w35und: fix usb_control_msg() error handling in wb35

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <497DFB04.1040802@cs.helsinki.fi>
Date:	Mon, 26 Jan 2009 20:03:48 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Greg KH <greg@...ah.com>
CC:	Pavel Machek <pavel@...e.cz>,
	Sandro Bonazzola <sandro.bonazzola@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] w35und: fix usb_control_msg() error handling in	wb35_probe()

Greg KH wrote:
> On Thu, Jan 22, 2009 at 12:06:33PM +0200, Pekka J Enberg wrote:
>> From: Pekka Enberg <penberg@...helsinki.fi>
>>
>> If successful, the usb_control_msg() function returns the number of
>> bytes transferred. Fix up wb35_probe() to only bail out if the function
>> returns a negative number.
>>
>> Reported-by: Sandro Bonazzola <sandro.bonazzola@...il.com>
>> Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> 
> I'm confused, should I apply this patch or not?

Yes, you should. What's confusing you here?

		Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/