linux-kernel - Re: [git pull] drm-fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Jan 2009 07:44:40 +1000
From:	Dave Airlie <airlied@...il.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Dave Airlie <airlied@...ux.ie>, dri-devel@...ts.sf.net,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [git pull] drm-fixes

On Tue, Jan 27, 2009 at 4:23 AM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
>
> Dave,
>  you have some odd and slightly git usage model, which shows up in various
> commits. Lookie here as an example from comit 335041ed:
>
>        Author: Jesse Barnes <jbarnes@...tuousgeek.org>  2009-01-22 04:22:06
>        Committer: Dave Airlie <airlied@...hat.com>  2009-01-22 04:22:06
>
>            drm/i915: hook up LVDS DPMS property
>
>            The LVDS output supports DPMS calls, but we never hooked up the property code,
>            so set property calls didn't actually do anything.  Implement a set_property
>            callback for the LVDS output so that the right thing happens.
>
>            Signed-off-by: Jesse Barnes <jbarnes@...tuousgeek.org>
>
> and this has a few issues that trigger my "Dave is doing something wrong"
> reaction:
>
>  - The signed-off-chain is incomplete from the author to the committer.
>
>   A _good_ sign-off will always have the sign-offs from the author and
>   the committer and everybody in between. This one does not. Clearly
>   Jesse did sign off on his work, but he is not listed as the committer:
>   you are. And that means that your sign-off is missing.

This one is my fault, I think I just cut-n-pasted the commit message
in my sleep,
and forgot to add my signoff.

>
>  - You are clearly lying about dates and/or dropping them.
>
>   The dates for authorship and committing are the same, yet the author
>   and committer are clearly _not_ the same. You can try to convince me
>   that you committed Jesse's work the same second he sent it to you, but
>   quite frankly, I don't buy it. End result: you've done something to
>   drop the date information

Well I'm not 100% sure what happened for this patch, I suspect,
jbarnes sent patch a week
or two ago, it misapplied against the tree I had currently when
applied with git-am, it didn't work so I hand
applied the patch with patch and then did git commit
--author="jbarnes" as he did write it, I just munged it.

Now I'm unsure how I should best handle this, in a world where I can
devote a lot more time to
maintaining this, I would sent Jesse a mail saying, rebase, he'd reply
with a rebase and I'd apply it,
however I generally find it easier to just fix this stuff up on the
run as its synchronous. Should
I be specifying a date somewhere in the commit message?

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/