linux-kernel - Re: [2.6.29-rc2-git2] compilation warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090127134854.1a9992fd@hyperion.delvare>
Date:	Tue, 27 Jan 2009 13:48:54 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Rufus & Azrael <rufus-azrael@...ericable.fr>,
	Linux-kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Jaswinder Singh Rajput <jaswinderlinux@...il.com>
Subject: Re: [2.6.29-rc2-git2] compilation warnings

Hi Takashi,

On Tue, 27 Jan 2009 10:34:20 +0100, Takashi Iwai wrote:
> At Tue, 27 Jan 2009 09:46:28 +0100,
> > On Tue, 27 Jan 2009 08:32:17 +0100, Takashi Iwai wrote:
> > > A bogus warning.  Ignore this.
> > 
> > No matter how bogus it is, it should be fixed. Otherwise this is
> > wasting the time of users and developers over and over again.
> 
> Well, it's a bug of gcc appearing only in a certain version, so most
> people won't see it.
> 
> Of course, we can put uninitialized_var().  But, I don't basically
> like adding it unconditionally... 

I didn't know about uninitialized_var(), thanks for the hint.

My experience with these warnings is that, in many cases, it is
possible to write the code differently so that it is clear to the
compiler that the variable is never used uninitialized. In some cases,
doing so also makes the code easier to read for humans and less likely
to break in the future.

Of course, in some cases the problem is simply that the compiler is too
stupid to understand even simple things, but in other cases these
warnings might be a good opportunity to rewrite the code in a way that
is easier to understand.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/