linux-kernel - Re: [PATCH 1/3] ide-cd: use ide_drive_t's rq in cdrom_queue_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Jan 2009 17:47:47 +0100
From:	Borislav Petkov <petkovbb@...glemail.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH 1/3] ide-cd: use ide_drive_t's rq in cdrom_queue_request_sense

On Tue, Jan 27, 2009 at 4:07 PM, Bartlomiej Zolnierkiewicz
<bzolnier@...il.com> wrote:
> On Monday 26 January 2009, Borislav Petkov wrote:
>> There should be no functionality change resulting from this patch.
>>
>> Suggested-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
>> Signed-off-by: Borislav Petkov <petkovbb@...il.com>
>> ---
>>  drivers/ide/ide-cd.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
>> index d3d5fb6..3907466 100644
>> --- a/drivers/ide/ide-cd.c
>> +++ b/drivers/ide/ide-cd.c
>> @@ -207,7 +207,7 @@ static void cdrom_queue_request_sense(ide_drive_t *drive, void *sense,
>>                                     struct request *failed_command)
>>  {
>>       struct cdrom_info *info         = drive->driver_data;
>> -     struct request *rq              = &info->request_sense_request;
>> +     struct request *rq              = &drive->request_sense_rq;
>
> Don't we want to also remove now unused ->request_sense_request?

sure we do :)

--
From: Borislav Petkov <petkovbb@...il.com>
Date: Tue, 27 Jan 2009 17:42:28 +0100
Subject: [PATCH 1/3] ide-cd: use ide_drive_t's rq in cdrom_queue_request_sense

There should be no functionality change resulting from this patch.

Suggested-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Signed-off-by: Borislav Petkov <petkovbb@...il.com>
---
 drivers/ide/ide-cd.c |    2 +-
 drivers/ide/ide-cd.h |    2 --
 2 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 3554dc4..bf4e7a0 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -205,7 +205,7 @@ static void cdrom_queue_request_sense(ide_drive_t
*drive, void *sense,
 				      struct request *failed_command)
 {
 	struct cdrom_info *info		= drive->driver_data;
-	struct request *rq		= &info->request_sense_request;
+	struct request *rq		= &drive->request_sense_rq;

 	ide_debug_log(IDE_DBG_SENSE, "enter");

diff --git a/drivers/ide/ide-cd.h b/drivers/ide/ide-cd.h
index 0b82233..b26d305 100644
--- a/drivers/ide/ide-cd.h
+++ b/drivers/ide/ide-cd.h
@@ -91,8 +91,6 @@ struct cdrom_info {
 	   on this device. */
 	struct request_sense sense_data;

-	struct request request_sense_request;
-
 	u8 max_speed;		/* Max speed of the drive. */
 	u8 current_speed;	/* Current speed of the drive. */

-- 
1.6.0.4

-- 
Regards/Gruss,
Boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/