linux-kernel - Re: [PATCH] pids: kill now unused signal_struct-> __pgrp/_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090126211354.a4f38be2.akpm@linux-foundation.org>
Date:	Mon, 26 Jan 2009 21:13:54 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Cedric Le Goater <clg@...ibm.com>,
	Dave Hansen <haveblue@...ibm.com>,
	Eric Biederman <ebiederm@...ssion.com>,
	Pavel Emelyanov <xemul@...nvz.org>,
	Serge Hallyn <serue@...ibm.com>,
	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, Alan Cox <number6@...-village.bc.nu>,
	Ian Kent <raven@...maw.net>, "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] pids: kill now unused signal_struct-> __pgrp/__session
 and friends

On Mon, 19 Jan 2009 23:05:54 +0100 Oleg Nesterov <oleg@...hat.com> wrote:

> [PATCH -mm] pids: kill signal_struct-> __pgrp/__session and friends
> 
> (depends on pids-refactor-vnr-nr_ns-helpers-to-make-them-safe.patch)
> 
> We are wasting 2 words in signal_struct without any reason to implement
> task_pgrp_nr() and task_session_nr().
> 
> task_session_nr() has no callers since 2e2ba22ea4fd4bb85f0fa37c521066db6775cbef,
> we can remove it.
> 
> task_pgrp_nr() is still (I believe wrongly) used in fs/autofsX and fs/coda.
> 
> This patch reimplements task_pgrp_nr() via task_pgrp_nr_ns(), and kills
> __pgrp/__session and the related helpers.
> 
> The change in drivers/char/tty_io.c is cosmetic, but hopefully makes sense
> anyway.

hm, that's a fairly deep-looking patch.

You missed the fun bit:

 drivers/char/tty_io.c |    4 +--
 include/linux/sched.h |   43 +++++-----------------------------------
 kernel/exit.c         |   10 ++-------
 kernel/fork.c         |    2 -
 kernel/sys.c          |    4 ---
 5 files changed, 12 insertions(+), 51 deletions(-)

> TTY-parts-Acked-by: Alan Cox <number6@...-village.bc.nu>

who is that masked man?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/