linux-kernel - Re: [PATCH] OMAP HSMMC: fix MMC3 dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <498018BD.2000806@nokia.com>
Date:	Wed, 28 Jan 2009 10:35:09 +0200
From:	Adrian Hunter <ext-adrian.hunter@...ia.com>
To:	Grazvydas Ignotas <notasas@...il.com>
CC:	"tony@...mide.com" <tony@...mide.com>,
	"drzeus-mmc@...eus.cx" <drzeus-mmc@...eus.cx>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] OMAP HSMMC: fix MMC3 dma

Grazvydas Ignotas wrote:
> On Tue, Jan 27, 2009 at 2:02 PM, Adrian Hunter
> <ext-adrian.hunter@...ia.com> wrote:
>> Grazvydas Ignotas wrote:
>>> Data transfers on third OMAP3 MMC controller don't work
>>> because DMA line numbers are only defined for MMC1 and MMC2.
>>> Fix that and store line numbers in mmc_omap_host structure
>>> to reduce code size.
>>> Tested on OMAP3 pandora board.
>>>
>>> Signed-off-by: Grazvydas Ignotas <notasas@...il.com>
>>> ---
>>>  drivers/mmc/host/omap_hsmmc.c |   31 +++++++++++++++++++++++--------
>>>  1 files changed, 23 insertions(+), 8 deletions(-)
>>>
>> Have you considered using the scatter-gather emulation patch:
>>
>>        http://marc.info/?l=linux-omap&m=122726069922195&w=2
>>
>> It was reverted:
>>
>>        http://marc.info/?l=linux-omap&m=122904725322787&w=2
>>
>> because of a hardware problem with OMAP3430 before ES3.0, but applying:
>>
>>
>>  http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=6a79e391df295bd7c2aa1309ea5031f361c197fd
>>
>> seems to overcome even that.
> 
> Hmm, but it still doesn't know about MMC3. But in case that SG patch
> goes first, I can resend.

I just meant, you might be interested because it gives better performance.

No, it doesn't know about MMC3, but it does hit some of the same lines of
code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/