linux-kernel - Re: [patch 016/104] epoll: introduce resource usage limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1233134693.21525.1297159411@webmail.messagingengine.com>
Date:	Wed, 28 Jan 2009 20:24:53 +1100
From:	"Bron Gondwana" <brong@...tmail.fm>
To:	"Davide Libenzi" <davidel@...ilserver.org>,
	"Greg KH" <gregkh@...e.de>
Cc:	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	stable@...nel.org, "Justin Forbes" <jmforbes@...uxtx.org>,
	"Zwane Mwaikambo" <zwane@....linux.org.uk>,
	"Theodore Ts'o" <tytso@....edu>,
	"Randy Dunlap" <rdunlap@...otime.net>,
	"Dave Jones" <davej@...hat.com>,
	"Chuck Wolber" <chuckw@...ntumlinux.com>
Subject: Re: [patch 016/104] epoll: introduce resource usage limits



On Tue, 27 Jan 2009 22:57 -0800, "Davide Libenzi" <davidel@...ilserver.org> wrote:
> On Tue, 27 Jan 2009, Davide Libenzi wrote:
> 
> > Or, like Willy said, make (for -stable) the default unlimited, and 
> > let sysadmins to put the bounds if they feel the DoS can apply to them.
> 
> Whose patch follows ...

ACK.

Solves my problem and my "advocate of the poor suffering sysadmins who
have to track down why their stuff suddenly broke with a stable update
hat" problem as well.

One wondering...

> -       if (unlikely(atomic_read(&user->epoll_devs) >=
> -                       max_user_instances))
> +       if (atomic_read(&user->epoll_devs) >= max_user_instances)
>  		goto free_uid;

Any reason this has become _less_ unlikely()?

Thanks,

Bron.


-- 
  Bron Gondwana
  brong@...tmail.fm

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/