linux-kernel - Re: [PATCH tip 1/1] blktrace: Use tracing_reset_online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090128145817.GA627@ghostprotocols.net>
Date:	Wed, 28 Jan 2009 12:58:17 -0200
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Frédéric Weisbecker <fweisbec@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Jens Axboe <jens.axboe@...cle.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH tip 1/1] blktrace: Use tracing_reset_online_cpus

Em Wed, Jan 28, 2009 at 03:53:48PM +0100, Frédéric Weisbecker escreveu:
> 2009/1/28 Arnaldo Carvalho de Melo <acme@...stprotocols.net>:
> > Impact: cleanup
> >
> > Use tracing_reset_online_cpus instead of open coding it.
> >
> > Cc: Jens Axboe <jens.axboe@...cle.com>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> >
> > diff --git a/block/blktrace.c b/block/blktrace.c
> > index 1b2267c..04d81d3 100644
> > --- a/block/blktrace.c
> > +++ b/block/blktrace.c
> > @@ -1109,12 +1109,7 @@ static void blk_tracer_print_header(struct seq_file *m)
> >
> >  static void blk_tracer_start(struct trace_array *tr)
> >  {
> > -       int cpu;
> > -
> > -       tr->time_start = ftrace_now(tr->cpu);
> > -
> > -       for_each_online_cpu(cpu)
> > -               tracing_reset(tr, cpu);
> > +       tracing_reset_online_cpus(tr);
> >
> >        mutex_lock(&blk_probe_mutex);
> >        if (atomic_add_return(1, &blk_probes_ref) == 1)
> >
> 
> Adding Steven in Cc, he uses to relay tracing patches as patchsets
> pull request to Ingo.

Ok, will add him for the next one.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/