linux-kernel - Re: [PATCH] trace: Use tracing_reset_online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c62985530901280706x61b4e4d1nbb43913f9b53e07@mail.gmail.com>
Date:	Wed, 28 Jan 2009 16:06:00 +0100
From:	Frédéric Weisbecker <fweisbec@...il.com>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] trace: Use tracing_reset_online_cpus in more places

2009/1/28 Arnaldo Carvalho de Melo <acme@...stprotocols.net>:
> Impact: cleanup
>
> Cc: Frédéric Weisbecker <fweisbec@...il.com>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
>
> diff --git a/kernel/trace/trace_branch.c b/kernel/trace/trace_branch.c
> index ca017e0..1284145 100644
> --- a/kernel/trace/trace_branch.c
> +++ b/kernel/trace/trace_branch.c
> @@ -133,11 +133,7 @@ static void stop_branch_trace(struct trace_array *tr)
>
>  static int branch_trace_init(struct trace_array *tr)
>  {
> -       int cpu;
> -
> -       for_each_online_cpu(cpu)
> -               tracing_reset(tr, cpu);
> -
> +       tracing_reset_online_cpus(tr);
>        start_branch_trace(tr);
>        return 0;
>  }
> diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
> index 66fc7b8..c97594d 100644
> --- a/kernel/trace/trace_functions_graph.c
> +++ b/kernel/trace/trace_functions_graph.c
> @@ -52,15 +52,11 @@ static struct tracer_flags tracer_flags = {
>
>  static int graph_trace_init(struct trace_array *tr)
>  {
> -       int cpu, ret;
> -
> -       for_each_online_cpu(cpu)
> -               tracing_reset(tr, cpu);
> -
> -       ret = register_ftrace_graph(&trace_graph_return,
> +       int ret = register_ftrace_graph(&trace_graph_return,
>                                        &trace_graph_entry);
>        if (ret)
>                return ret;
> +       tracing_reset_online_cpus(tr);
>        tracing_start_cmdline_record();
>
>        return 0;
> diff --git a/kernel/trace/trace_nop.c b/kernel/trace/trace_nop.c
> index b9767ac..087b6cb 100644
> --- a/kernel/trace/trace_nop.c
> +++ b/kernel/trace/trace_nop.c
> @@ -47,12 +47,8 @@ static void stop_nop_trace(struct trace_array *tr)
>
>  static int nop_trace_init(struct trace_array *tr)
>  {
> -       int cpu;
>        ctx_trace = tr;
> -
> -       for_each_online_cpu(cpu)
> -               tracing_reset(tr, cpu);
> -
> +       tracing_reset_online_cpus(tr);
>        start_nop_trace(tr);
>        return 0;
>  }
>

Thanks :-)

Acked-by: Frederic Weisbecker <fweisbec@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/