| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <497FD76E.1060909@schaufler-ca.com> Date: Tue, 27 Jan 2009 19:56:30 -0800 From: Casey Schaufler <casey@...aufler-ca.com> To: LKLM <linux-kernel@...r.kernel.org>, LSM <linux-security-module@...r.kernel.org>, jmorris@...ei.org CC: "Ahmed S. Darwish" <darwish.07@...il.com>, akpm@...ux-foundation.org, torvalds@...ux-foundation.org Subject: [PATCH] smackfs load append mode fix From: Casey Schaufler <casey@...aufler-ca.com> Given just how hard it is to find the code that uses MAY_APPEND it's probably not a big surprise that this went unnoticed for so long. The Smack rules loading code is incorrectly setting the MAY_READ bit when MAY_APPEND is requested. Signed-off-by: Casey Schaufler <casey@...aufler-ca.com> --- security/smack/smackfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -uprN -X linux-2.6/Documentation/dontdiff linux-2.6/security/smack/smackfs.c linux-0112/security/smack/smackfs.c --- linux-2.6/security/smack/smackfs.c 2009-01-09 21:43:42.000000000 -0800 +++ linux-0112/security/smack/smackfs.c 2009-01-19 11:05:09.000000000 -0800 @@ -334,7 +334,7 @@ static ssize_t smk_write_load(struct fil break; case 'a': case 'A': - rule.smk_access |= MAY_READ; + rule.smk_access |= MAY_APPEND; break; default: goto out; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists