[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090129001849.9f8fdcb3.akpm@linux-foundation.org>
Date: Thu, 29 Jan 2009 00:18:49 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Daisuke Nishimura <nishimura@....nes.nec.co.jp>
Cc: Christoph Lameter <cl@...ux-foundation.org>,
Johannes Weiner <hannes@...xchg.org>,
LKML <linux-kernel@...r.kernel.org>,
linux-mm <linux-mm@...ck.org>
Subject: Re: [PATCH] migration: migrate_vmas should check "vma"
On Thu, 29 Jan 2009 10:16:23 +0900 Daisuke Nishimura <nishimura@....nes.nec.co.jp> wrote:
> On Wed, 28 Jan 2009 17:55:12 +0100, Johannes Weiner <hannes@...xchg.org> wrote:
> > On Wed, Jan 28, 2009 at 11:42:36AM -0500, Christoph Lameter wrote:
> > > On Wed, 28 Jan 2009, Daisuke Nishimura wrote:
> > >
> > > > migrate_vmas() should check "vma" not "vma->vm_next" for for-loop condition.
> > >
> > > The loop condition is checked before vma = vma->vm_next. So the last
> > > iteration of the loop will now be run with vma = NULL?
> >
> > No, the condition is always checked before the body is executed. The
> > assignment to vma->vm_next happens at the end of every body.
> >
> So, I think in current code the loop body is not executed
> about the last vma in the list.
>
Yep.
Is this serious enough to bother fixing in 2.6.29?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists