linux-kernel - Re: [PATCH 1/6] input: bcm5974: Prepare for a new trackpad header type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090129003321.e9c8c36c.akpm@linux-foundation.org>
Date:	Thu, 29 Jan 2009 00:33:21 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Henrik Rydberg" <rydberg@...omail.se>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] input: bcm5974: Prepare for a new trackpad header
 type

On Wed, 28 Jan 2009 11:23:44 +0100 "Henrik Rydberg" <rydberg@...omail.se> wrote:

> static int report_tp_state(struct bcm5974 *dev, int size)
>  {
>  	const struct bcm5974_config *c = &dev->cfg;
> -	const struct tp_finger *f = dev->tp_data->finger;
> +	const struct tp_finger *f;
>  	struct input_dev *input = dev->input;
> -	const int fingers = (size - 26) / 28;
> -	int raw_p, raw_w, raw_x, raw_y;
> +	int raw_p, raw_w, raw_x, raw_y, raw_n;
>  	int ptest = 0, origin = 0, nmin = 0, nmax = 0;
>  	int abs_p = 0, abs_w = 0, abs_x = 0, abs_y = 0;
>  
> -	if (size < 26 || (size - 26) % 28 != 0)
> +	if (size < c->tp_offset || (size - c->tp_offset) % SIZEOF_FINGER != 0)
>  		return -EIO;
>  
> +	f = (const struct tp_finger *)(dev->tp_data + c->tp_offset);

Is there anything which guarantees that `f' is sufficiently aligned? 
If not, the code might cause unaligned exceptions on some
architectures?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/