linux-kernel - Re: x86: unify genapic code, unify subarchitectures, remove old subarchitecture code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vdryw6ql.fsf@basil.nowhere.org>
Date:	Thu, 29 Jan 2009 15:02:10 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: x86: unify genapic code, unify subarchitectures, remove old subarchitecture code

Ingo Molnar <mingo@...e.hu> writes:
>
> So breakages are to be expected. The commits are queued up in
> tip/x86/apic and are in tip/master as well:
>
>     http://people.redhat.com/mingo/tip.git/README

I haven't read it all, but the stuff I looked at looked
all reasonable and indeed cleaned up the 32bit code significantly
(and be neutral on 64bit). Thanks for doing that work.

My suggestion would be to deprecate and then remove es7000 and
numaq too. The es7000 subarch is only for very old es7000 systems (the
newer ones all work with bigsmp) and I expect the user base is very
likely zero or very near it. For NUMAQ it's similar -- there's
apparently one system left at IBM, and I'm sure IBM can find some
replacement. Especially NUMAQ has some ugly ifdefery outside the
subarch code too that would be good to remove. Overall that would
be a good cleanup without impacting the user base really.

Also bigsmp is kind of obsolete too, it could be probably
merged with default with very tiny impact because it's not
all that different.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/