linux-kernel - Re: [PATCH -mmotm] mm: unify some pmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0901292101430.17617@anakin>
Date:	Thu, 29 Jan 2009 21:02:29 +0100 (CET)
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Andrea Righi <righi.andrea@...il.com>, linux-mm@...ck.org,
	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	Roman Zippel <zippel@...ux-m68k.org>,
	David Howells <dhowells@...hat.com>,
	Hirokazu Takata <takata@...ux-m32r.org>
Subject: Re: [PATCH -mmotm] mm: unify some pmd_*() functions

On Tue, 27 Jan 2009, Andrew Morton wrote:
> On Sun, 25 Jan 2009 22:35:37 +0100
> Andrea Righi <righi.andrea@...il.com> wrote:
> 
> > diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h
> > index a7cdc48..b132d69 100644
> > --- a/include/asm-generic/pgtable-nopmd.h
> > +++ b/include/asm-generic/pgtable-nopmd.h
> > @@ -4,6 +4,7 @@
> >  #ifndef __ASSEMBLY__
> >  
> >  #include <asm-generic/pgtable-nopud.h>
> > +#include <asm/bug.h>
> >  
> >  struct mm_struct;
> >  
> 
> Why not include the preferred <linux/bug.h>?
> 
> > BTW, I only tested this on x86 and x86_64. This needs more testing because it
> > touches also a lot of other architectures.
> 
> Hopefully Geert, Roman, David and Hirokazu Takata will have time to
> help out here.

atari_defconfig builds fine and boots on ARAnyM.

sun3_defconfig fails with:

|   CC      mm/memory.o
| mm/memory.c: In function 'free_pmd_range':
| mm/memory.c:176: error: implicit declaration of function '__pmd_free_tlb'
| mm/memory.c: In function '__pmd_alloc':
| mm/memory.c:2903: error: implicit declaration of function 'pmd_alloc_one_bug'
| mm/memory.c:2903: warning: initialization makes pointer from integer without a cast
| mm/memory.c:2917: error: implicit declaration of function 'pmd_free'
| make[3]: *** [mm/memory.o] Error 1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/