linux-kernel - Re: [PATCH 3/6] integrity: IMA display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1233321251.3602.3.camel@localhost.localdomain>
Date:	Fri, 30 Jan 2009 08:14:11 -0500
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	James Morris <jmorris@...ei.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>,
	Dave Hansen <dave@...ux.vnet.ibm.com>,
	"<David Safford" <safford@...son.ibm.com>,
	Serge Hallyn <serue@...ibm.com>, Mimi Zohar <zohar@...ibm.com>
Subject: Re: [PATCH 3/6] integrity: IMA display

On Fri, 2009-01-30 at 20:18 +1100, James Morris wrote:
> On Thu, 29 Jan 2009, Mimi Zohar wrote:
> 
> > +int ima_fs_init(void)
> > +{
> > +	ima_dir = securityfs_create_dir("ima", NULL);
> > +	if (!ima_dir || IS_ERR(ima_dir))
> > +		return -1;
> > +
> > +	binary_runtime_measurements =
> > +	    securityfs_create_file("binary_runtime_measurements",
> > +				   S_IRUSR | S_IRGRP, ima_dir, NULL,
> > +				   &ima_measurements_ops);
> > +	if (!binary_runtime_measurements || IS_ERR(binary_runtime_measurements))
> > +		goto out;
> 
> You should not be checking for NULL returns from securityfs_create_file(), 
> because it does not return NULL (the documentation is wrong).
> 
> 
> - James

Thanks!

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/