linux-kernel - Re: [PATCH 09/13] atmel-mci: convert to dma_request_channel and down-level dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090131.014050.126762132.anemo@mba.ocn.ne.jp>
Date:	Sat, 31 Jan 2009 01:40:50 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	dan.j.williams@...el.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	maciej.sosnowski@...el.com, hskinnemoen@...el.com,
	g.liakhovetski@....de, nicolas.ferre@...el.com
Subject: Re: [PATCH 09/13] atmel-mci: convert to dma_request_channel and
 down-level dma_slave

On Fri, 14 Nov 2008 14:35:03 -0700, Dan Williams <dan.j.williams@...el.com> wrote:
> dma_request_channel provides an exclusive channel, so we no longer need to
> pass slave data through dmaengine.
> 
> Cc: Haavard Skinnemoen <haavard.skinnemoen@...el.com>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

Sorry for late review... I hope not too late.

> @@ -789,23 +782,17 @@ static int dwc_alloc_chan_resources(struct dma_chan *chan,
>  	cfghi = DWC_CFGH_FIFO_MODE;
>  	cfglo = 0;
>  
> -	slave = client->slave;
> -	if (slave) {
> +	dws = dwc->dws;
> +	if (dws) {
>  		/*
>  		 * We need controller-specific data to set up slave
>  		 * transfers.
>  		 */
> -		BUG_ON(!slave->dma_dev || slave->dma_dev != dw->dma.dev);
> -
> -		dws = container_of(slave, struct dw_dma_slave, slave);
> +		BUG_ON(!dws->dma_dev || dws->dma_dev != dw->dma.dev);
>  
> -		dwc->dws = dws;

How dw_dma_slave passed to the dw_dmac driver?  I cannot see where
dwc->dws is initialized now.  Or am I missing something?

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/