lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <49838F39.6060603@zytor.com>
Date:	Fri, 30 Jan 2009 15:37:29 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Martin Hicks <mort@....com>
CC:	tglx@...utronix.de, mingo@...hat.com, heukelum@...lshack.com,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: push old stack address on irqstack for unwinder

Martin Hicks wrote:
> Hi,
> 
> KDB was using this information.  Could this be pushed towards 2.6.29 please?
> 
> This re-adds the old stack pointer to the top of the irqstack to help
> with unwinding.  It was removed in commit d99015b1abbad743aa049b439c1e1dede6d0fa49
> as part of the save_args out-of-line work.
> 

This bothers me... why should we add even a single instruction to what 
is arguably the single hottest path in the kernel to support an 
out-of-tree debugger, especially if kgdb (which is in-tree) doesn't need it?

What does kgdb do differently (or is kgdb broken too)?

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ