linux-kernel - Re: [PATCH] intel-iommu: intel_iommu_domain_alloc should check 'dmar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090131044454.GA5184@bombadil.infradead.org>
Date:	Fri, 30 Jan 2009 23:44:54 -0500
From:	Kyle McMartin <kyle@...hat.com>
To:	Bhavesh Davda <bhavesh@...are.com>
Cc:	"David.Woodhouse@...el.com" <David.Woodhouse@...el.com>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] intel-iommu: intel_iommu_domain_alloc should check
	'dmar_disabled'

On Fri, Jan 16, 2009 at 03:54:12PM -0800, Bhavesh Davda wrote:
> 
> intel_iommu_domain_alloc() will try and iommu_alloc_domain(iommu),
> which calls alloc_domain_mem() to allocate out of 'iommu_domain_cache'.
> Unfortunately iommu_domain_cache will not be created if booted with
> "intel_iommu=off", i.e. dmar_disabled = 1.
> 

Hi Bhavesh,

What's the callchain that can result in intel_iommu_domain_alloc
being called? It looks like most possible callsites are checking
intel_iommu_found, which will be 0 since we check dmar_disabled before
calling init_dmars to enumerate the iommus.

(I'm looking at 2.6.28.y right now, is there an interim between when you
 stumbled upon this two weeks ago and git head where it's no longer an
 issue? I guess it probably got missed due to folks travelling for LCA.)

regards, Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/