linux-kernel - Re: [PATCH 1/4] kthreads: move sched-realeted initialization from kthreadd context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200901312117.17082.rusty@rustcorp.com.au>
Date:	Sat, 31 Jan 2009 21:17:16 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Hellwig <hch@....de>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Ingo Molnar <mingo@...e.hu>,
	Pavel Emelyanov <xemul@...nvz.org>,
	Vitaliy Gusev <vgusev@...nvz.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] kthreads: move sched-realeted initialization from kthreadd context

On Friday 30 January 2009 23:03:50 Oleg Nesterov wrote:
> (on top of kthread-dont-looking-for-a-task-in-create_kthread-2.patch)

Hi Oleg,

   Thanks for the cc: Vitaliy, I never saw that patch.  I've included it in my queue now.

As to this patch, it seems marginal.  I've never been convinced that we should
be trying to rescue root if they choose to set kthreadd's prio anyway, but I'm also wondering why we care about kthread_create scalability!

Still, I'm happy to apply it with one change:

> +		/*
> +		 * root may have changed our (kthreadd's) priority or CPU mask.
> +		 * The kernel thread should not inherit these properties.
> +		 */
> +		sched_setscheduler_nocheck(create.result, SCHED_NORMAL, &param);
> +		set_user_nice(create.result, KTHREAD_NICE_LEVEL);
> +		set_cpus_allowed_ptr(create.result, CPU_MASK_ALL_PTR);

cpu_all_mask is the non-deprecated replacement for CPU_MASK_ALL_PTR.

Thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/