linux-kernel - Re: [PATCH] kbuild: drop check for CONFIG_ in headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200901310206.41053.arnd@arndb.de>
Date:	Sat, 31 Jan 2009 02:06:40 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Sam Ravnborg <sam@...nborg.org>,
	Jaswinder Singh Rajput <jaswinder@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: drop check for CONFIG_ in headers_check

On Saturday 31 January 2009, Ingo Molnar wrote:
> hm, that looks quite ugly and unnatural. Could the usr/* exporting scripts 
> convert these types automatically to the __kernel_* versions?

It's possible, but there are some minor complications, e.g. linux/coda.h has
its own magic code that would likely break in the process, so it needs
to be skipped. Some other files conditionally include <sys/types.h> or
<stdint.h> in user space and would break in a similar way.

For the __kernel_ types, we have 87 instances in the tree, and 53 more that
would have to change. For the int types, there are over 4000 instances
of the correct __u32 style and about 800 that use the u_int32_t or
uint32_t style, most of them in netfilter and linux/pfkeyv2.h.

I'd probably leave at least the drm, netfilter and mtd headers alone,
as they are known to be working and consistently use the stdint.h types.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/