linux-kernel - Re: [PATCH D 01/11] OMAP: Add clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090131142344.GM1394@n2100.arm.linux.org.uk>
Date:	Sat, 31 Jan 2009 14:23:44 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Paul Walmsley <paul@...an.com>
Cc:	linux-arm-kernel@...ts.arm.linux.org.uk,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	Måns Rullgård <mans@...sr.com>,
	Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH D 01/11] OMAP: Add clk_get_parent() for OMAP2/3

On Thu, Jan 29, 2009 at 11:29:31PM -0700, Paul Walmsley wrote:
> On Thu, 29 Jan 2009, Russell King - ARM Linux wrote:
> 
> > On Wed, Jan 28, 2009 at 12:18:16PM -0700, Paul Walmsley wrote:
> > > From: Mans Rullgard <mans@...sr.com>
> > > 
> > > This makes clk_get_parent() work on OMAP2/3.
> > 
> > This is clearly something that the generic code should be doing.
> > It's not something specific to OMAP2/3.  Please move it to
> > arch/arm/plat-omap/clock.c
> 
> Done; revised patch below.

Great, thanks.  However, I'd forgotten that one of my patches completely
removes clk_get_parent() since it's unused by any code in OMAP at present.

What was the reasoning behind making this work?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/