linux-kernel - Re: checkpatch.pl is getting too slow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1233437719.5903.33.camel@desktop>
Date:	Sat, 31 Jan 2009 13:35:19 -0800
From:	Daniel Walker <dwalker@...o99.com>
To:	Andy Whitcroft <apw@...onical.com>
Cc:	Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org
Subject: Re: checkpatch.pl is getting too slow

On Sat, 2009-01-31 at 21:02 +0000, Andy Whitcroft wrote:
> On Sat, Jan 31, 2009 at 10:55:07AM -0800, Greg KH wrote:
> > Hi Andy,
> > 
> > I've noticed that checkpatch.pl is getting slower and slower when run on
> > a whole file, but yesterday I realized that it now is pretty much
> > unusable:
> > 
> > $ time ./scripts/checkpatch.pl --file drivers/staging/uc2322/aten2011.c
> > 
> > <snip>
> > total: 168 errors, 126 warnings, 3939 lines checked
> > 
> > drivers/staging/uc2322/aten2011.c has style problems, please review.  If any of these errors
> > are false positives report them to the maintainer, see
> > CHECKPATCH in MAINTAINERS.
> > 
> > real	8m7.924s
> > user	8m7.058s
> > sys	0m0.116s
> 
> That is scarey indeed.  Something is very wrong in there if it went back
> to a more reasonable 10's of seconds with a few patches.  I will have a
> look at the file you attached and see what I can find.
> 
> Thanks for the heads up.

The way your doing updates makes bisecting this code way too difficult..
I bisected this down to the commit for version 0.15 , but if you had all
the 0.15 patches as discrete git commits I could have actually found the
specific patch causing the problem ..

Could you start doing one fix or change per git commit?

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/