linux-kernel - Re: [linux-pm] [PATCH 2/3] PCI PM: Let the core be more careful with respect to drivers using new framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Feb 2009 13:06:40 +1100
From:	Nigel Cunningham <ncunningham@...a.org.au>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Linux PCI <linux-pci@...r.kernel.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [linux-pm] [PATCH 2/3] PCI PM: Let the core be more careful
 with respect to drivers using new framework

Hi Rafael.

Just a couple of typos in the comment:

On Sun, 2009-02-01 at 22:33 +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> Currently, the PM core always attempts to manage devices with drivers
> that use the new PM framework.  In particular, it attempts to disable
> the devices (which is unnecessary), to save their state (which may be
> undesirable if the driver has done that already) and to put them into
> low power states (again, this may be undesirable if the driver has
> already put the device into a low power state).  That need not be
> the right thing to do, so make the core be more careful in this
> respect.
> 
> Generally, there are the following categories of devices to consider:
> * bridge devices without drivers
> * non-bridge devices without drivers
> * bridge devices with drivers
> * non-bridge devices with drivers
> and each of them should be handled differently.
> 
> For bridge devices without drivers the PCI PM core will save their
> state on suspend and restore it (early) during resume, after putting
> them into D0 if necessary.  It will not attepmt to do anything else

s/attepmt/attempt/

> to these devices.
> 
> For non-bridge devices without drivers the PCI PM core will disable
> them and save their state on suspend.  During resume, it will put
> them into D0, if necessary, restore their state (early) and reenable
> them.
> 
> For bridge devices without drivers the PCI PM core will only save

s/without/with/

> their state on suspend if the driver hasn't done that already.
> Still, the core will restore their state (early) during resume,
> after putting them into D0, if necessary.
> 
> For non-bridge devices with drivers the PCI PM core will only save
> their state on suspend if the driver hasn't done that already.  Also,
> if the state of the device hasn't been saved by the driver, the core
> will attempt to put the device into a low power state.  During
> resume the core will restore the state of the device (early), after
> putting it into D0, if necessary.
> 
> For all devices the core will disable wake-up during resume.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>

I'm not pretending to understand the gory details of the code itself,
and so don't want you to add a Reviewed-by or such like for me, thanks.

Regards,

Nigel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/