linux-kernel - Re: [PATCH -mmotm] mm: unify some pmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 02 Feb 2009 14:48:46 +0100
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Andrea Righi <righi.andrea@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Roman Zippel <zippel@...ux-m68k.org>,
	David Howells <dhowells@...hat.com>,
	Hirokazu Takata <takata@...ux-m32r.org>
Subject: Re: [PATCH -mmotm] mm: unify some pmd_*() functions fix

On Thu, 2009-01-29 at 00:04 +0100, Andrea Righi wrote:
> Also unify implementations of pmd_*() functions in arch/*.
> 
> This patch must be applied on top of mm-unify-some-pmd_-functions.patch.
> 
> Signed-off-by: Andrea Righi <righi.andrea@...il.com>

> diff --git a/arch/s390/include/asm/pgalloc.h b/arch/s390/include/asm/pgalloc.h
> index b2658b9..6a85281 100644
> --- a/arch/s390/include/asm/pgalloc.h
> +++ b/arch/s390/include/asm/pgalloc.h
> @@ -63,8 +63,7 @@ static inline unsigned long pgd_entry_type(struct mm_struct *mm)
>  #define pud_alloc_one(mm,address)		({ BUG(); ((pud_t *)2); })
>  #define pud_free(mm, x)				do { } while (0)
> 
> -#define pmd_alloc_one(mm,address)		({ BUG(); ((pmd_t *)2); })
> -#define pmd_free(mm, x)				do { } while (0)
> +#define pmd_alloc_one	pmd_alloc_one_bug
> 
>  #define pgd_populate(mm, pgd, pud)		BUG()
>  #define pgd_populate_kernel(mm, pgd, pud)	BUG()

This does not compile for 32 bit s390. With the patches for 'dynamic
page tables' and '1K/2k page tables' I decided to get completely
independent from the nopmd/nopud #ifdef hell. The include files from
asm-generic are simply not used for s390. Please drop the above hunk
from your patch and leave s390 as it is.

-- 
blue skies,
  Martin.

"Reality continues to ruin my life." - Calvin.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/