linux-kernel - [PATCH] Fix sata_sil compilation error with libata debug enabled (2.6.29-rcX)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090202194714.GN15052@edu.joroinen.fi>
Date:	Mon, 2 Feb 2009 21:47:14 +0200
From:	Pasi Kärkkäinen <pasik@....fi>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH] Fix sata_sil compilation error with libata debug enabled (2.6.29-rcX)

Hello!

I tried compiling 2.6.29-rc1 and 2.6.29-rc3 with libata debugging enabled
and got the following error:

  CC [M]  drivers/ata/sata_sil.o
drivers/ata/sata_sil.c: In function 'sil_fill_sg':
drivers/ata/sata_sil.c:327: error: 'pi' undeclared (first use in this function)
drivers/ata/sata_sil.c:327: error: (Each undeclared identifier is reported only once
drivers/ata/sata_sil.c:327: error: for each function it appears in.)
make[2]: *** [drivers/ata/sata_sil.o] Error 1
make[1]: *** [drivers/ata] Error 2
make: *** [drivers] Error 2

include/linux/libata.h has the following enabled:

#define ATA_DEBUG
#define ATA_VERBOSE_DEBUG
#define ATA_IRQ_TRAP

The attached patch fixes the compilation.. I'm not sure if it's the correct
fix, but looking at the code it seems correct.. or at least makes the
code compile for me :)

-- Pasi

View attachment "sata_sil-libata-debug-compilation-error.patch" of type "text/x-diff" (376 bytes)