linux-kernel - Re: [PATCH] rtc: add rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2009 14:26:13 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ed Swierk <eswierk@...stanetworks.com>
Cc:	a.zummo@...ertech.it, rtc-linux@...glegroups.com,
	tglx@...utronix.de, mingo@...hat.com, linux-kernel@...r.kernel.org,
	Roman Zippel <zippel@...ux-m68k.org>
Subject: Re: [PATCH] rtc: add rtc_systohc for ntp use

On Mon, 26 Jan 2009 17:04:22 -0800
Ed Swierk <eswierk@...stanetworks.com> wrote:

> Following up to Alessandro's RFC of 10 Nov 2008, this patch implements
> rtc_systohc() to update the configured rtc device (cmos, i2c, etc.) from
> the ntp-synchronized system clock.  It changes the ntp update code to
> call rtc_systohc() rather than update_persistent_clock() which (at least
> on x86) always updates the cmos rtc.
> 
> No attempt is made to compensate for the 500-ms delay imposed when
> setting a cmos rtc chip.  If you actually have a cmos rtc you can stick
> with the existing code, but at some point it would be nice to unify
> these.

I don't get this.  Do we not currently update the cmos clock in
response to NTP controls?  Does the patch now alter this policy, by now
updating the RTC?

IOW: what effect does this patch actually have upon the kernel?

Please cc Roman on NTP changes.  Roman, please consider sending in a
MAINTAINERS patch for this.

Please use scripts/checkpatch.pl.

Please fix the checkpatch warnings which this patch emits.

When fixing the extern-declaration-in-C warning, please consider
dropping the ifdefs around the rtc_systohc() declaration in the header
file.  They're not really needed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/