linux-kernel - Re: [PATCH 3/3] pcf50633_charger: Enable periodic charging restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2009 14:41:31 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Balaji Rao <balajirrao@...nmoko.org>
Cc:	linux-kernel@...r.kernel.org, cbou@...l.ru, andy@...nmoko.com
Subject: Re: [PATCH 3/3] pcf50633_charger: Enable periodic charging restart

On Tue, 27 Jan 2009 19:23:12 +0530
Balaji Rao <balajirrao@...nmoko.org> wrote:

> @@ -157,6 +213,7 @@ pcf50633_mbc_irq_handler(int irq, void *data)
>  		mbc->usb_online = 0;
>  		mbc->usb_active = 0;
>  		pcf50633_mbc_usb_curlim_set(mbc->pcf, 0);
> +		cancel_delayed_work_sync(&mbc->charging_restart_work);
>  	}

eek, can't call cancel_delayed_work_sync() from an interrupt handler! 
If the work was actually running on this CPU or on a different one,
cancel_delayed_work_sync() will need to wait for it to complete.  The
kernel will explode in many tinkly little pieces.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/