linux-kernel - Re: PCI PM: Restore standard config registers of all devices early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0902021617390.3247@localhost.localdomain>
Date:	Mon, 2 Feb 2009 16:21:20 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jesse.barnes@...el.com>,
	Andreas Schwab <schwab@...e.de>, Len Brown <lenb@...nel.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: PCI PM: Restore standard config registers of all devices early



On Tue, 3 Feb 2009, Benjamin Herrenschmidt wrote:
> 
> > * Memory allocations with GFP_KERNEL are made, which is even worse, because
> >   we really shouldn't do that during suspend _at_ _all_, even during the regular
> >   ->suspend() with interrupts on, because there's not guarantee that swap will
> >   will be available at that time.  So, for the sake of correctness, we should
> >   get rid of the GFP_KERNEL from the ACPI code paths executed during
> >   suspend-resume anyway.
> 
> Well, as I said, this is a problem with more than just ACPI and again, I
> don't think the fix is to be done in ACPI itself. The buddy and slab
> should basically stick NOIO or ATOMIC to any allocation done after we
> started suspending the system.

We already do have magic code for things like PF_MEMALLOC (recursion), or 
TIF_MEMDIE (oom) or "(rt_task(p)) && !in_interrupt()" (give RT tasks 
higher priorities) in the page allocator.

Having a special case for NOT_RUNNING wouldn't be _pretty_, but it 
certainly isn't totally unreasonable either.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/