linux-kernel - Re: /proc/sys/vm/drop_caches: add error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090203204456.ECA3.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Tue,  3 Feb 2009 20:47:56 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Pavel Machek <pavel@...e.cz>
Cc:	kosaki.motohiro@...fujitsu.com,
	kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, linux-mm <linux-mm@...ck.org>
Subject: Re: /proc/sys/vm/drop_caches: add error handling

> 
> Document that drop_caches is unsafe, and add error checking so that it
> bails out on invalid inputs. [Note that this was triggered by Android
> trying to use it in production, and incidentally writing invalid
> value...]

Yup. good patch.

> -	return 0;
> +	int res;
> +	res = proc_dointvec_minmax(table, write, file, buffer, length, ppos);
> +	if (res)
> +		return res;
> +	if (!write)
> +		return res;
> +	if (sysctl_drop_caches & ~3)
> +		return -EINVAL;
> +	if (sysctl_drop_caches & 1)
> +		drop_pagecache();
> +	if (sysctl_drop_caches & 2)
> +		drop_slab();
> +	return res;
>  }

I think following is clarify more.

	res = proc_dointvec_minmax(table, write, file, buffer, length, ppos);
	if (res)
		return res;
	if (!write)
		return 0;
	if (sysctl_drop_caches & ~3)
		return -EINVAL;
	if (sysctl_drop_caches & 1)
		drop_pagecache();
	if (sysctl_drop_caches & 2)
		drop_slab();
	return 0;


otherthings, _very_ looks good to me. :)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/