linux-kernel - Re: [PATCH 2/2 v2] softlockup: check all tasks in hung

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090203122346.GE19979@elte.hu>
Date:	Tue, 3 Feb 2009 13:23:46 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Mandeep Singh Baines <msb@...gle.com>
Cc:	Frédéric Weisbecker <fweisbec@...il.com>,
	linux-kernel@...r.kernel.org, rientjes@...gle.com,
	mbligh@...gle.com, thockin@...gle.com,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/2 v2] softlockup: check all tasks in hung_task


* Mandeep Singh Baines <msb@...gle.com> wrote:

> +		if (sysctl_hung_task_check_count && !(max_count--)) {
> +			max_count = sysctl_hung_task_check_count;

just a minor nit, why not:

	!--max_count

?

That way we can lose the parenthesis and we'll also not overcount and wont 
let max_count go down to -1.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/