linux-kernel - Re: [PATCH v2] NOHZ: fix nohz on cpu unplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090203122847.GG19979@elte.hu>
Date:	Tue, 3 Feb 2009 13:28:47 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Christian Borntraeger <borntraeger@...ibm.com>
Cc:	Suresh Siddha <suresh.b.siddha@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>
Subject: Re: [PATCH v2] NOHZ: fix nohz on cpu unplug


* Christian Borntraeger <borntraeger@...ibm.com> wrote:

> Am Tuesday 03 February 2009 00:57:03 schrieb Suresh Siddha:
> > Does this patch fix the issue? Thanks.
> 
> I fixed up a compile error. (See below). After that, the patch does indeed fix 
> the problem.
> 
> Tested-by: Christian Borntraeger <borntraeger@...ibm.com>
> 
> 
> > diff --git a/kernel/sched.c b/kernel/sched.c
> > index 96439a4..8a0419b 100644
> > --- a/kernel/sched.c
> > +++ b/kernel/sched.c
> > @@ -4026,19 +4026,24 @@ int select_nohz_load_balancer(int stop_tick)
> >  	int cpu = smp_processor_id();
> >
> >  	if (stop_tick) {
> > -		cpumask_set_cpu(cpu, nohz.cpu_mask);
> >  		cpu_rq(cpu)->in_nohz_recently = 1;
> >
> > -		/*
> > -		 * If we are going offline and still the leader, give up!
> > -		 */
> > -		if (!cpu_active(cpu) &&
> > -		    atomic_read(&nohz.load_balancer) == cpu) {
> > +		if (!cpu_active(cpu) {
> 
> That does not compile...I used the following:
> 		if (!cpu_active(cpu)) {

Could you please resubmit an updated patch?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/