linux-kernel - Re: [PATCH tip 1/1] blktrace: fix coding style in recent patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090203152416.GH29046@elte.hu>
Date:	Tue, 3 Feb 2009 16:24:16 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jens Axboe <jens.axboe@...cle.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH tip 1/1] blktrace: fix coding style in recent patches


* Arnaldo Carvalho de Melo <acme@...hat.com> wrote:

> Impact: cleanup
>     
> I introduced some, then, while testing with checkpatch --file
> block/blktrace.c I saw some long lines and fixed those too, some were
> even from older patches I sent, shame on me ;-\
>     
> Cc: Jens Axboe <jens.axboe@...cle.com>
> Reported-by: Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

applied to tip:tracing/blktrace, thanks Arnaldo!

btw., there's only one warning remaining in all of blktrace.c:

| CHECK: memory barrier without comment
| #555: FILE: blktrace.c:555:
| +			smp_mb();
|
| total: 0 errors, 1 warnings, 1 checks, 1549 lines checked

and here checkpatch is kind of right that we should document this particular 
smp_mb(). If you stick a comment in front of that statement, explaining that 
barrier, then checkpatch will stop complaining.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/