linux-kernel - Re: PCI PM: Restore standard config registers of all devices early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1233625606.18767.157.camel@pasglop>
Date:	Tue, 03 Feb 2009 12:46:46 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jesse.barnes@...el.com>,
	Andreas Schwab <schwab@...e.de>, Len Brown <lenb@...nel.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: PCI PM: Restore standard config registers of all devices early


> Note how the PCI layer (currently) only saves the low _16_ dwords of 
> config space (64 bytes). The radeonfb code that did it by hand saved the 
> whole 64 dwords (256 bytes). It _probably_ doesn't matter, but..
> 
> The reason the PCI layer only does 64 bytes is that that was the really 
> old PCI config space model - the rest was undefined and apparently a few 
> cards reportedly even crashed when accessing it (but who knows, that may 
> be urban folklore).
> 
> But if that patch works for you, it's clearly already better than _not_ 
> applying the patch, so..

Radeons don't do much with config space... the worst we may miss I
suppose is subsystem vendor/device... Maybe I'll add something to
explicitely save and restore it or X might get upset. I'll have a look.

At some point, that whole code will migrate out of radeonfb into the new
radeon DRM with kernel mode setting in which case even X should stop
caring ... mostly.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/