linux-kernel - Re: [GIT PULL -tip] fix 22 make headers_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090204141804.GB4411@elte.hu>
Date:	Wed, 4 Feb 2009 15:18:04 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Jaswinder Singh Rajput <jaswinder@...nel.org>,
	Herbert Xu <herbert@...dor.apana.org.au>, x86@...nel.org,
	sam@...nborg.org, hpa@...or.com, jirislaby@...il.com,
	gregkh@...e.de, davem@...emloft.net, xyzzy@...akeasy.org,
	mchehab@...radead.org, jens.axboe@...cle.com,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Avi Kivity <avi@...hat.com>
Subject: Re: [GIT PULL -tip] fix 22 make headers_check - 200901


* Arnd Bergmann <arnd@...db.de> wrote:

> On Wednesday 04 February 2009, Jaswinder Singh Rajput wrote:
> > On Wed, 2009-02-04 at 17:43 +1100, Herbert Xu wrote:
> > > > -#include <asm/types.h>
> > > > +#include <linux/types.h>
> > > > #include <linux/ioctl.h>
> > > 
> > > Awesome, you've just broken the userspace build of kvm as the
> > > file linux/types.h conflicts with sys/types.h.
> > > 
> > 
> > What I did is absolutely right.
> > 
> > If there is any conflict then we need to solve it in better way.
> > 
> > Can you please share what is the conflict and what you are expecting and
> > what you are getting.
> 
> I fear that the problem might be more widespread than just kvm.
> The problem is that <linux/types.h> without __KERNEL_STRICT_NAMES
> defines the standard types that glibc provides in its own <sys/types.h>,
> some of them even defined differently (e.g. the size of off_t depends
> __USE_FILE_OFFSET64).
> 
> You should be able to do
> 
> #include <sys/types.h>
> #define __KERNEL_STRICT_NAMES
> #include <linux/types.h>
> 
> or
> 
> #include <sys/types.h>
> #include <asm/types.h>
> 
> but not without the __KERNEL_STRICT_NAMES! This means that the
> mass-conversion to <linux/types.h> was flawed and should be fixed
> before 2.6.29 to avoid more trouble.

agreed.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/