linux-kernel - Re: [PATCH] ACPI: add missing KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200902041628.03675.elendil@planet.nl>
Date:	Wed, 4 Feb 2009 16:28:00 +0100
From:	Frans Pop <elendil@...net.nl>
To:	Frank Seidel <fseidel@...e.de>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	linux-acpi@...r.kernel.org, linux-pm@...ts.linux-foundation.org,
	len.brown@...el.com, shaohuhua.li@...el.com,
	kristen.c.accardi@...el.com, frank@...eidel.de, fseidel@...e.de
Subject: Re: [PATCH] ACPI: add missing KERN_* constants to printks

Frank Seidel wrote:
> +++ b/drivers/acpi/pci_link.c
> @@ -593,7 +593,7 @@ static int acpi_pci_link_allocate(struct
>                 return -ENODEV;
>         } else {
>                 acpi_irq_penalty[link->irq.active] += PIRQ_PENALTY_PCI_USING;
> -               printk(PREFIX "%s [%s] enabled at IRQ %d\n",
> +               printk(KERN_WARNING PREFIX "%s [%s] enabled at IRQ %d\n",
>                 acpi_device_name(link->device),
>                 acpi_device_bid(link->device), link->irq.active);
>         }
> @@ -751,21 +751,21 @@ static int acpi_pci_link_add(struct acpi
>         acpi_device_bid(device));
>         for (i = 0; i < link->irq.possible_count; i++) {
>                 if (link->irq.active == link->irq.possible[i]) {
> -                       printk(" *%d", link->irq.possible[i]);
> +                       printk(KERN_INFO " *%d", link->irq.possible[i]);
>                         found = 1;
>                 } else
> -                       printk(" %d", link->irq.possible[i]);
> +                       printk(KERN_INFO " %d", link->irq.possible[i]);
>         }
> 
> -       printk(")");
> +       printk(KERN_INFO ")");
> 
>         if (!found)
> -               printk(" *%d", link->irq.active);
> +               printk(KERN_INFO " *%d", link->irq.active);
> 

This patch looks broken to me, at least for some of your changes.
For example, in the bit quoted above all printks together make up
*one single* message, which means that only the _first_ of the
printks should have the KERN_* prefix. printks that are continuations
should not have the prefix.

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/