linux-kernel - Re: mmotm 2009-02-03-19-43 uploaded (cirrusfb)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090204131258.b9029211.akpm@linux-foundation.org>
Date:	Wed, 4 Feb 2009 13:12:58 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	linux-kernel@...r.kernel.org, krzysztof.h1@...zta.fm
Subject: Re: mmotm 2009-02-03-19-43 uploaded (cirrusfb)

On Wed, 04 Feb 2009 09:28:57 -0800
Randy Dunlap <randy.dunlap@...cle.com> wrote:

> akpm@...ux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2009-02-03-19-43 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> > 
> > and will soon be available at
> > 
> >    git://git.zen-sources.org/zen/mmotm.git
> > 
> > It contains the following patches against 2.6.29-rc3:
> 
> > cirrusfb-convert-printks-to-dev_foo.patch
> 
> -	DPRINTK("\n");
> +	dev_dbg(info->device, "\n");

Actually

		dev_dbg(info->device,
			"cirrusfb_setup: option '%s'\n", this_opt);

> 
> drivers/video/cirrusfb.c:2397: error: 'info' undeclared (first use in this function)
> 
> 
> Did you build test this??

As a module - that code is inside #ifdef MODULE.

I did the easy fix ;)

--- a/drivers/video/cirrusfb.c~cirrusfb-convert-printks-to-dev_foo-fix-fix2
+++ a/drivers/video/cirrusfb.c
@@ -2384,7 +2384,8 @@ static int __init cirrusfb_init(void)
 }
 
 #ifndef MODULE
-static int __init cirrusfb_setup(char *options) {
+static int __init cirrusfb_setup(char *options)
+{
 	char *this_opt;
 
 	if (!options || !*options)
@@ -2394,9 +2395,6 @@ static int __init cirrusfb_setup(char *o
 		if (!*this_opt)
 			continue;
 
-		dev_dbg(info->device,
-			"cirrusfb_setup: option '%s'\n", this_opt);
-
 		if (!strcmp(this_opt, "noaccel"))
 			noaccel = 1;
 		else if (!strncmp(this_opt, "mode:", 5))
_




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/