linux-kernel - Re: [PATCH] xen: disable interrupts before saving in percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4988FBBD.9020608@kernel.org>
Date:	Tue, 03 Feb 2009 18:21:49 -0800
From:	"H. Peter Anvin" <hpa@...nel.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	Ingo Molnar <mingo@...e.hu>,
	the arch/x86 maintainers <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Xen-devel <xen-devel@...ts.xensource.com>,
	Stable Kernel <stable@...nel.org>
Subject: Re: [PATCH] xen: disable interrupts before saving in percpu

Jeremy Fitzhardinge wrote:
> H. Peter Anvin wrote:
>> Jeremy Fitzhardinge wrote:
>>  
>>> xen_mc_batch has a small preempt race where it takes the address of a
>>> percpu variable immediately before disabling interrupts, thereby
>>> leaving a small window in which we may migrate to another cpu and save
>>> the flags in the wrong percpu variable.  Disable interrupts before
>>> saving the old flags in a percpu.
>>>     
>>
>> Applied to tip:core/xen, thanks!
> 
> Can you push this Linusward too?
> 

Just merged into tip:core/urgent, so it should end up in the next set of
pull requests.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/