linux-kernel - Re: [PATCH 2/2] posix-cpu-timers: use ->sighand instead of ->signal to check the task is alive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090205033120.2294BFC381@magilla.sf.frob.com>
Date:	Wed,  4 Feb 2009 19:31:20 -0800 (PST)
From:	Roland McGrath <roland@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, Lin Ming <ming.m.lin@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] posix-cpu-timers: use ->sighand instead of ->signal to
	check the task is alive

> It doesn't matter which pointer to check under tasklist to ensure the task
> was not released, ->signal or ->sighand. But we are going to make ->signal
> refcountable, change the code to use ->sighand.

I haven't been following what that's about (signal_struct already has two
atomic counts!).  Uses here protecting cpu_clock_sample_group() e.g., are
around looking at ->signal->foobar, so if ->signal is still there, why not
look at it and be able to get the sample in whatever small window this is?

I don't really understand what this new case might mean though.  Most
things that look at ->signal need to lock it, so access doesn't make any
sense if there is no siglock because ->sighand is clear while ->signal is not.

Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/