linux-kernel - Re: [PATCH] Separate FMODE_PREAD/FMODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090204194310.1d5e96ae.akpm@linux-foundation.org>
Date:	Wed, 4 Feb 2009 19:43:10 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Paul Turner <pjt@...gle.com>, linux-kernel@...r.kernel.org,
	adobriyan@...il.com, ebierderm@...ssion.com, stable@...nel.org,
	Al Viro <viro@...iv.linux.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] Separate FMODE_PREAD/FMODE_PWRITE into separate flags

On Wed, 4 Feb 2009 19:42:03 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:

> And I updated seq_file-properly-cope-with-pread.patch thusly:
> 
> --- a/fs/seq_file.c~seq_file-properly-cope-with-pread-fix
> +++ a/fs/seq_file.c
> @@ -48,6 +48,16 @@ int seq_open(struct file *file, const st
>  	 */
>  	file->f_version = 0;
>  
> +	/*
> +	 * seq_files support lseek() and pread().  They do not implement
> +	 * write() at all, but we clear FMODE_PWRITE here for historical
> +	 * reasons.
> +	 *
> +	 * If a client of seq_files a) implements file.write() and b) wishes to
> +	 * support pwrite() then that client will need to implement its own
> +	 * file.open() which calls seq_open() and then sets FMODE_WRITE.
                                                                  ^P
> +	 */
> +	file->f_mode &= ~FMODE_PWRITE;
>  	return 0;
>  }
>  EXPORT_SYMBOL(seq_open);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/