linux-kernel - Re: Missing unistd_no.h and unistd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Feb 2009 06:53:37 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Missing unistd_no.h and unistd_mm.h export on m68k

On Wed, Feb 04, 2009 at 01:46:59PM -0500, Lennart Sorensen wrote:
> On Wed, Feb 04, 2009 at 01:31:42PM -0500, Lennart Sorensen wrote:
> > On Wed, Feb 04, 2009 at 01:14:53PM -0500, Lennart Sorensen wrote:
> > > make header_install fails to include the files unistd_no.h and
> > > unistd_mm.h on m68k, while those two files are included by unistd.h.
> > > 
> > > This patch fixes this by adding these two files to the list of m68k
> > > specific headers to export.
> > > 
> > > Signed-off-by: Len Sorensen <lsorense@...lub.uwaterloo.ca>
> > > 
> > > Signed
> > > diff --git a/arch/m68k/include/asm/Kbuild b/arch/m68k/include/asm/Kbuild
> > > index 1a922fa..2bb4738 100644
> > > --- a/arch/m68k/include/asm/Kbuild
> > > +++ b/arch/m68k/include/asm/Kbuild
> > > @@ -1,2 +1,2 @@
> > >  include include/asm-generic/Kbuild.asm
> > > -header-y += cachectl.h
> > > +header-y += cachectl.h unistd_no.h unistd_mm.h
> > 
> > Hmm, seems it is actually much worse than I thought.  All _no.h and
> > _mm.h are being missed, making m68k compiles of things like uclibc
> > rather broken.  Yuck.
> 
> So updated patch that makes uclibc actually compile for m68k.
> 
> -- 
> Len Sorensen
> 
> 
> 
> make header_install fails to include the files *_no.h and
> *_mm.h on m68k, while those files are included by the matching *.h
> 
> This patch fixes this by adding these missing files to the list of m68k
> specific headers to export.  With this patch, uclibc compiles again.

Hi Len.

Indeed the *_no.h, *_mm.h is missing from Kbuild.h.
But looking at your patch you added much more than the
missing *_no.h, *_mm.h.
When doing this do it in steps:
1) fix make headers_check
   This is fixed by adding the *_no.h,*_mm.h for files that
   are exported. And that is the files lited in include/asm-generic/Kbuild.asm
   plus the single file listed in the m68k Kbuld file.

2) then as a separate patch export the additional files needed to build
   ulibc.
   Do it file-by-file so you are sure you do not add a single file
   that is not needed. We want to have a minimal set of files exported.

And when you prepare your patch please use one line per header file,
as we do in all the ohter Kbuild files.

	Sam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/