[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <498ADFE3.9020907@vmware.com>
Date: Thu, 05 Feb 2009 13:47:31 +0100
From: Thomas Hellström <thellstrom@...are.com>
To: Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: 2.6.29 pat issue
Hi!
The function in include/linux/mm.h:
is_linear_pfn_mapping()
doesn't seem valid to me.
In particular, we have VMAs to graphics devices in which vma->vm_pgoff
is non-zero (Points to an offset in the drm device node), and the VMA is
sparsely populated with pfns pointing to uncached discontigous RAM pages.
This causes the X86 PAT code to hit the optimized path when it
shouldn't, and issue a warning.
Also a question about the philosofy behind this strict checking that all
PTEs have the same caching attributes: I guess this is only to catch
bugs in kernel drivers that don't get this right. At the same time, now
that also user-space VMAs are checked this will probably have a
significant performance impact. Shouldn't this checking really live
behind a debug define?
Thanks,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists