linux-kernel - Re: [PATCH 4/4] ptrace: fix possible zombie leak on PTRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 Feb 2009 15:41:35 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Roland McGrath <roland@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Jerome Marchand <jmarchan@...hat.com>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] ptrace: fix possible zombie leak on PTRACE_DETACH

On 02/04, Roland McGrath wrote:
>
> ACK on the change, though looks different if you put __ptrace_detach in
> ptrace.c with the earliar patch, as I suggest.  Also, I think this warrants
> a comment for the release_task call mentioning briefly what it means:
> 
> 	/*
> 	 * The flag means __ptrace_detach() determined that this child
> 	 * was a zombie that should have been auto-reaped already.
> 	 * Don't leak it.
> 	 */
> 	if (unlikely(dead))
> 		release_task(child);

OK, will add this to the cleanup patch too.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/