linux-kernel - Re: [RFC PATCH 03/10] PCI: properly clean up ASPM link state on device remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200902041637.45099.jbarnes@virtuousgeek.org>
Date:	Wed, 4 Feb 2009 16:37:44 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Alex Chiang <achiang@...com>
Cc:	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	Shaohua Li <shaohua.li@...el.com>
Subject: Re: [RFC PATCH 03/10] PCI: properly clean up ASPM link state on device remove

On Wednesday, January 28, 2009 1:59 pm Alex Chiang wrote:
> We only want to disable ASPM when the last function is removed from
> the parent's device list. We determine this by checking to see if
> the parent's device list is completely empty.
>
> Unfortunately, we never hit that code because the parent is considered
> an upstream port, and never had an ASPM link_state associated with it.
>
> The early check for !link_state causes us to return early, we never
> discover that our device list is empty, and thus we never remove the
> downstream ports' link_state nodes.
>
> Instead of checking to see if the parent's device list is empty, we can
> check to see if we are the last device on the list, and if so, then we
> know that we can clean up properly.
>
> Cc: Shaohua Li <shaohua.li@...el.com>
> Signed-off-by: Alex Chiang <achiang@...com>

Applied to my for-linus branch, thanks.  Let me know if you have a problem 
with it (fast) Shaohua! :)

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/