linux-kernel - Re: [PATCH] softlockup: convert read_lock in hung_task to rcu_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090205181329.GA5661@elte.hu>
Date:	Thu, 5 Feb 2009 19:13:29 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Mandeep Singh Baines <msb@...gle.com>
Cc:	Frédéric Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, rientjes@...gle.com,
	mbligh@...gle.com, thockin@...gle.com,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] softlockup: convert read_lock in hung_task to
	rcu_read_lock


* Mandeep Singh Baines <msb@...gle.com> wrote:

> Ingo Molnar (mingo@...e.hu) wrote:
> > 
> > I've applied your patch to tip:core/softlockup, thanks Mandeep!
> > 
> 
> Oops, I put the conversion to rcu_read_lock in a seperate patch. I
> understand now the convention is to use a patch series only when the
> patches can be applied independently.

What you did is in fact the preferred approach: keep independent stuff 
independent and make patches as gradual and split-up as possible. (as long 
as the interim state is a working kernel too)

> ---
> Since the tasklist is protected by rcu list operations, it is safe
> to convert the read_lock()s to rcu_read_lock().
> 
> Suggested-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Signed-off-by: Mandeep Singh Baines <msb@...gle.com>
> ---
>  kernel/hung_task.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Applied to tip:core/softlockup, thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/