[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <498B3913.2010701@codemonkey.ws>
Date: Thu, 05 Feb 2009 13:08:03 -0600
From: Anthony Liguori <anthony@...emonkey.ws>
To: Ingo Molnar <mingo@...e.hu>
CC: Glauber Costa <glommer@...hat.com>, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org, avi@...hat.com, akataria@...are.com,
Glauber Costa <gcosta@...hat.com>
Subject: Re: [PATCH 1/2] show hypervisor information on cpuinfo
Ingo Molnar wrote:
> * Glauber Costa <glommer@...hat.com> wrote:
>
>
>> +char * __cpuinit hypervisor_str(struct cpuinfo_x86 *c)
>> +{
>> + if (c->x86_hyper_vendor == X86_HYPER_VENDOR_VMWARE)
>> + return "VMWare";
>> + else
>> + return "none";
>> +}
>>
>
> i'd suggest these variants instead:
>
> virtualization: native kernel
>
I don't think "native kernel" really ports well to other architectures
(like s390 or PPC) that always have hypervisors present in some form. I
think "none" makes more sense in the case of bare metal x86.
Regards,
Anthony Liguori
> virtualization: KVM guest
> virtualization: VMWare guest
> virtualization: Linux guest
>
> Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists