linux-kernel - Re: [Patch] mmu_notifiers destroyed by __mmu_notifier_release() retain extra mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090205200214.GN8577@sgi.com>
Date:	Thu, 5 Feb 2009 14:02:14 -0600
From:	Robin Holt <holt@....com>
To:	Christoph Lameter <cl@...ux-foundation.org>
Cc:	Robin Holt <holt@....com>, linux-mm@...ck.org,
	Andrea Arcangeli <andrea@...ranet.com>,
	Nick Piggin <npiggin@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [Patch] mmu_notifiers destroyed by __mmu_notifier_release()
	retain extra mm_count.

On Thu, Feb 05, 2009 at 02:30:29PM -0500, Christoph Lameter wrote:
> The drop of the refcount needs to occur  after the last use of
> data in the mmstruct because mmdrop() may free the mmstruct.

Not this time.  We are being called from process termination and the
calling function is assured to hold one reference count.

We would also have to track how many callouts were made and then do
drops in a loop, but as stated above, I don't think it is needed.

Robin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/